D974: py3: handle keyword arguments correctly in hgext/patchbomb.py

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Sat Oct 7 08:49:09 EDT 2017


yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.


  and missing import of pycompat. Please make sure all tests pass.

INLINE COMMENTS

> patchbomb.py:618
>      if bundle:
>          opts['revs'] = [str(r) for r in revs]
>  

opts is modified here, but stropts isn't.  Perhaps we shouldn't
keep the copy for long.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D974

To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list