[PATCH 1 of 4] patch: rename "header" variable into "hdr" in diff()

Yuya Nishihara yuya at tcha.org
Tue Oct 10 09:18:46 EDT 2017


On Tue, 10 Oct 2017 08:52:36 +0200, Denis Laxalde wrote:
> Augie Fackler a écrit :
> > On Wed, Oct 04, 2017 at 05:03:59PM +0200, Denis Laxalde wrote:
> >> # HG changeset patch
> >> # User Denis Laxalde <denis.laxalde at logilab.fr>
> >> # Date 1506442667 -7200
> >> #      Tue Sep 26 18:17:47 2017 +0200
> >> # Node ID 3d8ed7dafee4676b49922a3dde0edf1b1fad63ec
> >> # Parent  2fd06499dc8e6a5a784b1334b925c289d7b54e4e
> >> # Available At http://hg.logilab.org/users/dlaxalde/hg
> >> #              hg pull http://hg.logilab.org/users/dlaxalde/hg -r 3d8ed7dafee4
> >> # EXP-Topic followlines-cli
> >> patch: rename "header" variable into "hdr" in diff()
> > 
> > I've taken this one, and discarded the rest of the stack per Yuya's
> > review on patch 2.
> 
> Unfortunately, this doesn't help since this patch is no longer in the v2
> I sent on Friday:
> 
>    https://patchwork-demo.mercurial-scm.org/project/hg/list/?series=298
> 
> Also, it will probably merge-conflict with the other ones. So I'd say
> you can drop it..

I think the patch itself is good to go since shadowing globals is generally
a bad idea. Can you send V3 if they conflict?


More information about the Mercurial-devel mailing list