[PATCH 10 of 11 V2] log: add obsfate by default in changeset printer

Yuya Nishihara yuya at tcha.org
Wed Oct 11 09:40:47 EDT 2017


On Wed, 11 Oct 2017 14:09:56 +0200, Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld <boris.feld at octobus.net>
> # Date 1507209918 -7200
> #      Thu Oct 05 15:25:18 2017 +0200
> # Node ID 79dd127e09281ca88332be9791016cf92936e4e8
> # Parent  4162251414fe06aec0bbe559a0262d8fdd49129a
> # EXP-Topic obsfatekeyword
> # Available At https://bitbucket.org/octobus/mercurial-devel/
> #              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r 79dd127e0928
> log: add obsfate by default in changeset printer

> +        elif ctx.obsolete():
> +            self.showobsfate(ctx)

Nit: could be marked as a private function.

> +    def showobsfate(self, ctx):
> +        obsfate = templatekw.showobsfate(repo=self.repo, ctx=ctx, ui=self.ui)
> +
> +        if obsfate:
> +            for obsfateline in obsfate:
> +                self.ui.write(_("obsfate:     %s\n") % obsfateline,
> +                              label='log.obsfate')

Nit: please add '# i18n: column positioning for "hg log"' comment
(FWIW, I don't know how the word "obsfate" would be translated.)


More information about the Mercurial-devel mailing list