D960: bundle2: immediate exit for ctrl+c (issue5692)

durham (Durham Goode) phabricator at mercurial-scm.org
Wed Oct 11 13:33:29 EDT 2017


durham added inline comments.

INLINE COMMENTS

> yuja wrote in bundle2.py:380
> SignalInterrupt is a subclass of KeyboardInterrupt, so there might
> be deeper problem.
> 
> FWIW, I think it's probably a good idea to replace this blacklist
> with `isinstance(exc, Exception)`.

Before my refactor there used to be two levels of error handling, 1) inside _parthandler which tried to seek to the end if it wasn't systemexit or keyboardinterrup, and 2) inside processbundle (which calls _parthandler) which only caught type Exception.

It seems like the correct unification of these would be to just keep the `isinstance(exc, Exception)` check above, and delete this sub-check entirely.  I'll send an update.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D960

To: durham, #hg-reviewers, quark
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list