D987: copies: add a config to limit the number of candidates to check in heuristics

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Wed Oct 11 14:34:32 EDT 2017


pulkit added a comment.


  In https://phab.mercurial-scm.org/D987#16792, @yuja wrote:
  
  > Oops, the default value (5 vs 100) wasn't my point. I doubt if taking the first n
  >  candidates would be a good "heuristic."
  
  
  Oh, sorry. I changed it to 100 as I think that will be a good maximum and a good default rather than 5.
  
  > If I understand correctly, it may miss the copy information only if the file is
  >  out of the n-candidates list. I think it would be hard for users to understand
  >  why the copy wasn't detected. That's my concern.
  
  I have added a debug message saying more candidates than the limit which can give user a hint in this case. Shall I make that a ui.status() thing?
  
  > (marked as "request changes" to flag discussion is ongoing. no new version is requested.)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D987

To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list