D1011: localrepo: add a _pinnedrevs attribute

dlax (Denis Laxalde) phabricator at mercurial-scm.org
Thu Oct 12 03:02:33 EDT 2017


dlax added inline comments.

INLINE COMMENTS

> repoview.py:38
>      pinned.update([par.rev() for par in repo[None].parents()])
>      pinned.update([cl.rev(bm) for bm in repo._bookmarks.values()])
>  

Updating a "private" attribute of an object outside the class is not nice.
Not sure about "our" common practice in this case, but maybe this could be handled through a property?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1011

To: pulkit, #hg-reviewers
Cc: dlax, mercurial-devel


More information about the Mercurial-devel mailing list