D738: directaccess: add support to export and tests to demonstrate things

ryanmce (Ryan McElroy) phabricator at mercurial-scm.org
Thu Oct 12 07:38:34 EDT 2017


ryanmce requested changes to this revision.
ryanmce added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> durham wrote in test-directaccess.t:64
> I'm still not sure we want to support rev numbers.  I think we definitely don't want to support them for write commands, even recoverable ones.

This is showing the rev numbers are not supported, right?

> test-directaccess.t:23-35
> +  o  6:87d6d66763085b629e6d7ed56778c79827273022 Added g
> +  |
> +  o  5:825660c69f0cd8d9542c1fea6e5d444c666f063b Added f
> +  |
> +  o  4:aa98ab95a9284d289c73a270d70c37914795a842 Added e
> +  |
> +  o  3:62615734edd52f06b6fb9c2beb429e4fe30d57b8 Added d

Why so many commits here? It seems to needlessly bloat the test.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D738

To: pulkit, #hg-reviewers, durham, ryanmce
Cc: ryanmce, durham, mercurial-devel


More information about the Mercurial-devel mailing list