D1019: logtoprocess: do not use platform.system()
ryanmce (Ryan McElroy)
phabricator at mercurial-scm.org
Thu Oct 12 10:53:06 EDT 2017
ryanmce requested changes to this revision.
ryanmce added a comment.
This revision now requires changes to proceed.
I'm +1 on this direction but think we shouldn't `have == 'nt'` as the "is this windows?" check here.
INLINE COMMENTS
> logtoprocess.py:55
> def uisetup(ui):
> - if platform.system() == 'Windows':
> + if pycompat.osname == 'nt':
> # no fork on Windows, but we can create a detached process
seems like this should be `pycompat.iswindows` (which probably doesn't exist yet, but should) because comparisons to things that should be constants scattered throughout the code scare me.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1019
To: quark, #hg-reviewers, ryanmce
Cc: ryanmce, mercurial-devel
More information about the Mercurial-devel
mailing list