D1011: localrepo: add a _pinnedrevs attribute
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Thu Oct 12 13:28:34 EDT 2017
pulkit added inline comments.
INLINE COMMENTS
> dlax wrote in repoview.py:38
> Updating a "private" attribute of an object outside the class is not nice.
> Not sure about "our" common practice in this case, but maybe this could be handled through a property?
Hm, I will turn that attribute to public in next version.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1011
To: pulkit, #hg-reviewers
Cc: dlax, mercurial-devel
More information about the Mercurial-devel
mailing list