D1033: pycompat: define operating system constants

[quark (Jun Wu)]

quark added inline comments.

INLINE COMMENTS

> spectral wrote in pycompat.py:24
> Ah, sorry, I didn't mean put it in the if blocks (duplicating it), I meant just put it at the end of the file once <thismodule>.osname and <thismodule>.sysplatform have been created in a python-version-aware fashion, not indented at all.  (basically, move these three lines to the end of the file).
> 
> Mostly this is paranoia and a tiny extra layer of abstraction/indirection.  I don't expect it to happen, but if sys.platform renames itself in some hypothetical future python 4.2, I expect we'll continue to have a pycompat.sysplatform, and then we shouldn't need to change these lines at all, if they're using that version-agnostic sysplatform.
> 
> I don't feel strongly about this though, and don't want to block you on this issue.  I leave it up to you and the 2nd pass reviewers :)

That makes sense. I will update the patch and the previous Jython one. Thanks!

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1033

To: quark, #hg-reviewers, spectral
Cc: spectral, mercurial-devel