D1037: check-code: suggest pycompat.is(posix|windows|darwin)
quark (Jun Wu)
phabricator at mercurial-scm.org
Fri Oct 13 02:36:43 EDT 2017
quark updated this revision to Diff 2659.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1037?vs=2640&id=2659
REVISION DETAIL
https://phab.mercurial-scm.org/D1037
AFFECTED FILES
contrib/check-code.py
CHANGE DETAILS
diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -397,6 +397,18 @@
(?P=quote))""", reppython),
]
+# non-filter patterns
+pynfpats = [
+ [
+ (r'pycompat\.osname\s*[=!]=\s*[\'"]nt[\'"]', "use pycompat.iswindows"),
+ (r'pycompat\.osname\s*[=!]=\s*[\'"]posix[\'"]', "use pycompat.isposix"),
+ (r'pycompat\.sysplatform\s*[!=]=\s*[\'"]darwin[\'"]',
+ "use pycompat.isdarwin"),
+ ],
+ # warnings
+ [],
+]
+
# extension non-filter patterns
pyextnfpats = [
[(r'^"""\n?[A-Z]', "don't capitalize docstring title")],
@@ -513,6 +525,7 @@
checks = [
('python', r'.*\.(py|cgi)$', r'^#!.*python', pyfilters, pypats),
+ ('python', r'.*\.(py|cgi)$', r'^#!.*python', [], pynfpats),
('python', r'.*hgext.*\.py$', '', [], pyextnfpats),
('python 3', r'.*(hgext|mercurial)/(?!demandimport|policy|pycompat).*\.py',
'', pyfilters, py3pats),
To: quark, #hg-reviewers, spectral
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list