D1028: mpatch: reformat function prototypes with clang-format

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Sat Oct 14 03:07:22 EDT 2017


durin42 added a comment.


  In https://phab.mercurial-scm.org/D1028#17513, @yuja wrote:
  
  > Seemed fine, but test-check-code.t says no.
  >
  >   +  mercurial/mpatch.c:268:
  >   +   >             ssize_t start, ssize_t end)
  >   +   don't use spaces to indent
  >   +  mercurial/mpatch.h:24:
  >   +   >             ssize_t start, ssize_t end);
  >   +   don't use spaces to indent
  >
  
  
  
  
  In https://phab.mercurial-scm.org/D1028#17513, @yuja wrote:
  
  > Seemed fine, but test-check-code.t says no.
  >
  >   +  mercurial/mpatch.c:268:
  >   +   >             ssize_t start, ssize_t end)
  >   +   don't use spaces to indent
  >   +  mercurial/mpatch.h:24:
  >   +   >             ssize_t start, ssize_t end);
  >   +   don't use spaces to indent
  >
  
  
  Ah. Okay. Since everyone at the sprint seemed loosely in favor of clang-format, how about this: I'll get the remaining trivial fixes from clang-format in, then land a test-check-clang-format.t with an extensive blacklist, then remove the check-code rules that are offended by clang-format as the series exposes them. That way we own less checking, and the formatting is done by a robot.
  
  That work?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1028

To: durin42, #hg-reviewers, pulkit, yuja
Cc: ryanmce, yuja, mercurial-devel


More information about the Mercurial-devel mailing list