D1092: peer: when collecting method names for batch calls, bytes-ify __name__

[durin42 (Augie Fackler)]

durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  This will explode violently if we have a non-ascii command name. That
  shouldn't ever happen in core, and seems unlikely even in third-party
  code. Regardless, it'll explode violently, so we can revisit things in
  the future if we need to change the encoding here.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1092

AFFECTED FILES
  mercurial/peer.py

CHANGE DETAILS

diff --git a/mercurial/peer.py b/mercurial/peer.py
--- a/mercurial/peer.py
+++ b/mercurial/peer.py
@@ -34,7 +34,9 @@
     def __getattr__(self, name):
         def call(*args, **opts):
             resref = future()
-            self.calls.append((name, args, opts, resref,))
+            # Please don't invent non-ascii method names, or you will
+            # give core hg a very sad time.
+            self.calls.append((name.encode('ascii'), args, opts, resref,))
             return resref
         return call
     def submit(self):



To: durin42, #hg-reviewers
Cc: mercurial-devel