D1096: releasenotes: make the import of fuzzywuzzy optional
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Mon Oct 16 09:05:56 EDT 2017
yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> releasenotes.py:222
> + try:
> + import fuzzywuzzy.fuzz as fuzz
> + except ImportError:
Needs to evaluate the fuzz module to get around the demandimport.
e.g.
try:
from fuzzywuzzy import fuzz
fuzz.token_set_ratio
except ImportError
> releasenotes.py:224
> + except ImportError:
> + return False
> merge = True
Perhaps it should return True.
Any maybe it should show warning, status or debug message?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1096
To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list