D1044: bisect: add --abort flag
quark (Jun Wu)
phabricator at mercurial-scm.org
Tue Oct 17 01:00:19 EDT 2017
quark abandoned this revision.
quark added a comment.
In https://phab.mercurial-scm.org/D1044#18824, @durin42 wrote:
> I'm confused what you think the state of this is: the proximate goal of this series (as I understood it!) was to get run-tests able to restore to an original revision after doing its bisection, a goal which I wholeheartedly endorse.
This series fixes other things, like the run-tests.py bisect does not work with a customized `log` template.
> While I also agree that some built-in-to-bisect mechanism for "take be back where I was before bisection began" probably makes sense,
> I disagree that it should be named --abort.
I'd like to make it a built-in bisect feature so `run-tests.py` does not need to implement the feature using a less reliable (shell script) way.
It's unlikely to reach an agreement about how (what flags or revsets) to implement it before the freeze. Therefore I'm abandoning these two patches.
> I've not looked at any of the earlier diffs in the series because @ryanmce requested changes, so much like a commented V1 on the list, I wasn't going to spend time on them until you sent a V2 (aka updated the diff, or otherwise cleared the "changes requested" state.) Does that make sense? I'm happy to land 947-949 assuming they're ready to go, but it looks like at least 948 needs some minor indentation cleanup?
I don't think @ryanmce requested changes fairly for the 1st and 3rd patch. I've pushed back.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1044
To: quark, #hg-reviewers, ryanmce
Cc: kulshrax, durin42, ryanmce, dlax, mercurial-devel
More information about the Mercurial-devel
mailing list