D1063: rebase: enable multidest by default

dlax (Denis Laxalde) phabricator at mercurial-scm.org
Tue Oct 17 03:02:45 EDT 2017


dlax added a comment.


  In https://phab.mercurial-scm.org/D1063#18725, @durin42 wrote:
  
  > (Note that I'd still welcome feedback from non-BigCo contributors here - is this something we should make permanent? Have people been testing this? Etc.)
  
  
  I have never tested this but it seems to me that this option enables a rather advanced behavior that would get rarely used (I cannot think of a situation where I'd need this FWIW). So having it on by default seems wrong to me.
  On the other hand, as said in the commit message, you already have to used //advanced// names `SRC` or `ALLSRC` to see the actual effect of this option, so maybe it's already fine. Ultimately, if it's really safe, why keeping the option at all?
  
  Anyways, I'd also welcome more feedback from people already using it, perhaps other people from FB could share their experience here?

INLINE COMMENTS

> rebase.py:645
> +    ``ALLSRC`` substituted by all source revisions.
> +
>      Rebase will destroy original changesets unless you use ``--keep``.

Maybe this could be in a `.. container:: verbose` block since it's an advanced feature?

> rebase.py:698
> + -d 'first(max((successors(max(roots(ALLSRC) & ::SRC)^)-obsolete())::) +\
> + max(::((roots(ALLSRC) & ::SRC)^)-obsolete()))'
> +

I'd also be very useful to have an example of how to stabilize only the current stack, but maybe this is unrelated to this changeset.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1063

To: quark, #hg-reviewers, durin42
Cc: dlax, martinvonz, durin42, mercurial-devel


More information about the Mercurial-devel mailing list