D1136: templatefilters: defend against evil unicode strs in json filter

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Tue Oct 17 09:50:35 EDT 2017


yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ryanmce wrote in templatefilters.py:241-242
> I fear that this is is an non-actionable error. How might I see it as a user? If I see it, what do I do?
> 
> Also, why is this a TypeError? Should this be a ProgrammingError instead? Or is there a way user input could trigger this?

It's okay to be non actionable error because it's plain wrong
to pass unicode to Mercurial functions. But I agree it should be
a ProgrammingError. TypeError in filter functions is caught
at templater.runfilter().

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1136

To: durin42, #hg-reviewers, yuja
Cc: yuja, ryanmce, mercurial-devel


More information about the Mercurial-devel mailing list