[PATCH 3 of 4 V2] phase: add a dedicated txnclose-phase hook

Martin von Zweigbergk martinvonz at google.com
Thu Oct 19 00:26:21 EDT 2017


On Wed, Oct 18, 2017 at 8:51 AM, Kevin Bullock <
kbullock+mercurial at ringworld.org> wrote:

> > On Oct 14, 2017, at 10:46, Boris Feld <boris.feld at octobus.net> wrote:
> >
> > # HG changeset patch
> > # User Boris Feld <boris.feld at octobus.net>
> > # Date 1507477846 -7200
> > #      Sun Oct 08 17:50:46 2017 +0200
> > # Node ID 06eeae1828afe149886e18e6b4fc8180a3803fdb
> > # Parent  e1aa5834b2423fd04b32965075e5dee2204768c2
> > # EXP-Topic b2.phases.hooks
> > # Available At https://bitbucket.org/octobus/mercurial-devel/
> > #              hg pull https://bitbucket.org/octobus/mercurial-devel/
> -r 06eeae1828af
> > phase: add a dedicated txnclose-phase hook
> >
> [snip]
> > diff --git a/tests/test-phases.t b/tests/test-phases.t
> > --- a/tests/test-phases.t
> > +++ b/tests/test-phases.t
> > @@ -2,6 +2,8 @@
> >   $ cat >> $HGRCPATH << EOF
> >> [extensions]
> >> phasereport=$TESTDIR/testlib/ext-phase-report.py
> > +  > [hooks]
> > +  > txnclose-phase.test = echo "test-hook-close-phase: \$HG_NODE:
> \$HG_OLDPHASE -> \$HG_PHASE"
> >> EOF
> >
> >   $ hglog() { hg log --template "{rev} {phaseidx} {desc}\n" $*; }
> > @@ -26,6 +28,7 @@
> >
> >   $ mkcommit A
> >   test-debug-phase: new rev 0:  x -> 1
> > +  test-hook-close-phase: 4a2df7238c3b48766b5e22fafbb8a2f506ec8256:
>  -> 1
>
> I don't think there's any other place where we expose numeric values for
> phase, and I'm not keen to start doing so now. Could you send a follow-up
> that changes these to the normal 'secret'/'draft'/'public' labels?
>

+1

I had not seen Kevin's comment when I was reviewing the queued patches just
now and looked up this thread just to make the same comment :-)


>
> pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
> Kevin R. Bullock
>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20171018/b104e2fe/attachment.html>


More information about the Mercurial-devel mailing list