D1106: context: add workingfilectx.markcopied

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Thu Oct 19 01:32:02 EDT 2017


martinvonz added inline comments.

INLINE COMMENTS

> context.py:1938
>  
> +    def markcopied(self, src):
> +        """marks this file a copy of `src`"""

I would probably have put this on workingctx instead (not per file). It feels like it better matches how copies are recorded in the dirstate (which is not per file). It looks like this would be a little simpler that way. Will future patches be simpler by doing it on the workingfilectx instead?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1106

To: phillco, #hg-reviewers, durin42
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list