[PATCH STABLE] test-static-http: flush access log per request

Yuya Nishihara yuya at tcha.org
Mon Oct 30 10:18:54 EDT 2017


On Sun, 29 Oct 2017 13:57:47 -0400, Matt Harbison wrote:
> On Sun, 29 Oct 2017 05:05:17 -0400, Yuya Nishihara <yuya at tcha.org> wrote:
> > # HG changeset patch
> > # User Yuya Nishihara <yuya at tcha.org>
> > # Date 1509267232 -32400
> > #      Sun Oct 29 17:53:52 2017 +0900
> > # Branch stable
> > # Node ID ce935a5de7737d4706d3f5d50184665f955017e3
> > # Parent  ee3492423f7c8b1a350b2596c247e1b97759d2d7
> > test-static-http: flush access log per request
> >
> > It appears that stderr is fully buffered on Windows.
> 
> Ugh, I should have known, since I had to fix this in multiple other places  
> before.  Long term, is there any reason that we can't use setvbuf() and  
> _IONBF, since there is no line buffering on Windows?
> 
> https://msdn.microsoft.com/en-us/library/86cebhfs.aspx

I doubt setvbuf() would be an easy workaround since stdio layer is likely to
have weird behavior. And it's completely written in Python 3 to not use the
platform fread/fwrite() API.

> This + the removal of the platform path separators fixes the test for me,
> thanks.

Thanks for testing them.


More information about the Mercurial-devel mailing list