D464: editor: use an unambiguous path suffix for editor files

quark (Jun Wu) phabricator at mercurial-scm.org
Fri Sep 1 16:10:35 EDT 2017


quark added inline comments.

INLINE COMMENTS

> mbolin wrote in test-editor-filename.t:7
> I think this has to change to:
> 
>   $ cat > $TESTTMP/editor.sh << EOF
> 
> to fix the FreeBSD build.

This is not the root test. `run-tests.py` guarantees the current directory is at `$TESTTMP` when the test starts.

> test-editor-filename.t:8
> +  $ cat > editor.sh << EOF
> +  > #!/bin/bash
> +  > echo "\$@"

FreeBSD does not have bash installed by default. Maybe we should have a check-rule for that. Removing this line and the test will pass.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D464

To: mbolin, quark, durin42, #hg-reviewers, ryanmce
Cc: yuja, smf, ryanmce, mercurial-devel


More information about the Mercurial-devel mailing list