D607: editor: file created for diff action should have .diff suffix

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Sat Sep 2 08:18:10 EDT 2017


yuja accepted this revision.
yuja added a comment.
This revision is now accepted and ready to land.


  I dropped the shebang fix and queued, thanks.

INLINE COMMENTS

> test-editor-filename.t:7
>  
> -  $ cat > editor.sh << EOF
> -  > #!/bin/bash
> +  $ cat > $TESTTMP/editor.sh << EOF
>    > echo "\$@"

This works, but seems not nice to force the kernel to detect
the type of executable. I'll send a follow up.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D607

To: mbolin, durin42, ryanmce, quark, #hg-reviewers, yuja
Cc: mercurial-devel


More information about the Mercurial-devel mailing list