D621: copytrace: replace experimental.disablecopytrace config with copytrace (BC)

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Wed Sep 6 09:53:31 EDT 2017


yuja accepted this revision.
yuja added a comment.
This revision is now accepted and ready to land.


  > experimental.copytrace defaults to 'off'. The new value is not boolean value as
  
  s/off/on/ and queued, thanks.

INLINE COMMENTS

> copies.py:366
>      # rebase.
> -    if repo.ui.configbool('experimental', 'disablecopytrace'):
> +    if repo.ui.config('experimental', 'copytrace') == 'off':
>          return {}, {}, {}, {}, {}

This could be kept as configbool so any falsy value could be
specified, but I don't have strong preference.

> copies.py:731
>      if (skiprev is not None and
> -        not repo.ui.configbool('experimental', 'disablecopytrace')):
> -        # disablecopytrace skips this line, but not the entire function because
> +        not (repo.ui.config('experimental', 'copytrace') == 'off')):
> +        # copytrace='off' skips this line, but not the entire function because

Updated to use !=.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D621

To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list