D625: copytrace: use the full copytracing method if only drafts are involved

[yuja (Yuya Nishihara)]

yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.


  > The `heuristics` option for `experimental.copytrace` performs full
  >  copytracing if drafts are involved.
  
  This sounds somewhat incorrect. One of the involved revisions should
  always be draft on rebase. Can you rephrase?

INLINE COMMENTS

> copies.py:373
>      elif copytracing == 'heuristics':
> +        # Do full copytracing if only drafts are involved
> +        if _isfullcopytraceable(c1, base):

Please comment "why" instead of "what this is doing."

> copies.py:388
> +
> +    if cdst.phase() == phases.draft and base.phase() == phases.draft:
> +        return True

What if some of them are "secret" ?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D625

To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel