D611: checknlink: use a random temp file name for checking

[yuja (Yuya Nishihara)]

yuja accepted this revision.
yuja added a comment.
This revision is now accepted and ready to land.


  Queued, thanks.

INLINE COMMENTS

> util.py:1465
> +        os.close(fd)
> +        fd = None
> +        f2 = '%s2~' % f1[:-2]

Nit: here fd is a file descriptor, but later it's changed to a file
object.  fd.close() would raise AttributeError if os.close(fd) failed.

Maybe we should rename the latter to fp or something. Can
you send a follow up?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D611

To: quark, #hg-reviewers, yuja
Cc: yuja, mercurial-devel