D642: checknlink: renmae file object from 'fd' to 'fp'

phillco (Phil Cohen) phabricator at mercurial-scm.org
Wed Sep 6 17:38:20 EDT 2017


phillco accepted this revision.
phillco added a comment.


  *rename
  
  LGTM

INLINE COMMENTS

> util.py:1460
>      # work around issue2543 (or testfile may get lost on Samba shares)
> -    f1, f2, fd = None, None, None
> +    f1, f2, fp = None, None, None
>      try:

Too bad there's no similar naming convention for paths.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D642

To: quark, #hg-reviewers, phillco
Cc: phillco, mercurial-devel


More information about the Mercurial-devel mailing list