D612: directaccess: add a hiddenlevel argument to registrar.command

durham (Durham Goode) phabricator at mercurial-scm.org
Wed Sep 6 21:53:28 EDT 2017


durham added inline comments.

INLINE COMMENTS

> registrar.py:142
> +            (recoverable write command)
> +        2: Can access the hidden commits without any warnings (read command)
>      """

I think an enum would be better here (UNRECOVERABLE_WRITE, RECOVERABLE_WRITE, READ_ONLY).  Especially because I think people generally copy and paste the registrar decorators from other functions, and if we're just specifying numbers they are more likely to just reuse whatever value they copied.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D612

To: pulkit, #hg-reviewers
Cc: durham, mercurial-devel


More information about the Mercurial-devel mailing list