D615: directaccess: store the access level in the ui object in dispatch
quark (Jun Wu)
phabricator at mercurial-scm.org
Thu Sep 7 02:00:09 EDT 2017
quark requested changes to this revision.
quark added a comment.
This revision now requires changes to proceed.
Setting `ui` config seems like an abuse of the config system. I think it'll be cleaner if feed the right "repo" object directly to the command function. i.e. By default commands get the "visible" repo: `repo.filtered('visible')` - see `hg.repository`. We can change that and add special filter - like `repo.fitlered('visible-directaccess-warn')`. So the `repo` object carries the information itself.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D615
To: pulkit, #hg-reviewers, quark
Cc: quark, mercurial-devel
More information about the Mercurial-devel
mailing list