D623: copytrace: move fast heuristic copytracing algorithm to core

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Thu Sep 7 05:59:56 EDT 2017


pulkit planned changes to this revision.
pulkit added inline comments.

INLINE COMMENTS

> yuja wrote in copies.py:608
> This cdst/csrc naming is confusing because c1 is actually the
> source revision (= the original wctx) in "update" scenario. And
> IIUC, we are searching for copies from c1 to c2.
> 
> Can you rename them?

Yes, sure. :)

> yuja wrote in copies.py:638
> Perhaps this wouldn't stop if the base were in the other side.
> I don't think that would happen thanks to how mergecopies()
> are used currently, but it's probably better to error out early.

I am sorry but I didn't understand the `base were in other side` thing. Did you mean base is a child of ctx?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D623

To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list