D612: directaccess: add a hiddenlevel argument to registrar.command

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Thu Sep 7 10:25:23 EDT 2017


yuja added inline comments.

INLINE COMMENTS

> durham wrote in registrar.py:142
> I think an enum would be better here (UNRECOVERABLE_WRITE, RECOVERABLE_WRITE, READ_ONLY).  Especially because I think people generally copy and paste the registrar decorators from other functions, and if we're just specifying numbers they are more likely to just reuse whatever value they copied.

nod. registrar.internalmerge() has a good example of pseudo enum.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D612

To: pulkit, #hg-reviewers
Cc: yuja, durham, mercurial-devel


More information about the Mercurial-devel mailing list