D656: revset: remove "small" argument from "_optimize"
quark (Jun Wu)
phabricator at mercurial-scm.org
Fri Sep 8 13:06:12 EDT 2017
quark added inline comments.
INLINE COMMENTS
> yuja wrote in revsetlang.py:421
> Any reason to choose 1 here and 0.5 for the others?
I think there are 2 factors deciding weight:
1. Time complexity of the revset implementation
2. The returned revset size (maybe more important for `and` optimization)
Here, `:` returns a larger revset so its weight is larger.
Maybe we can change all weight numbers to get rid of float numbers. ex. multiple by 10 for everything.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D656
To: quark, #hg-reviewers
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list