D529: uncommit: move fb-extension to core which uncommits a changeset

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Mon Sep 11 16:53:43 EDT 2017


pulkit marked 15 inline comments as done.
pulkit added inline comments.

INLINE COMMENTS

> yuja wrote in uncommit.py:173
> I'm not sure if this `retractboundary()` is valid. cmdutil.amend()
> appears to use phases.new-commit config instead.

The phases.new-commit config update the phase to old.phase() if `--secret` flag is not passed. Since we don't have that I think we can use `retractboundary` to directly update to old.phase()

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D529

To: pulkit, #hg-reviewers, quark, durham
Cc: durham, quark, martinvonz, yuja, mercurial-devel


More information about the Mercurial-devel mailing list