D616: context: add overlayworkingcontext and overlayworkingfilectx

phillco (Phil Cohen) phabricator at mercurial-scm.org
Mon Sep 11 18:14:57 EDT 2017


phillco added inline comments.

INLINE COMMENTS

> martinvonz wrote in context.py:2145-2149
> Unrelated to this patch, but this interface seems pretty uglily asymmetric (flags() returns a string of character flags, setflags() take two boolean flags). And that's why you're forced to make the flag handling in your setflags() above ugly.

Yes, it is. Possibly worth a future refactor.

> martinvonz wrote in context.py:2009
> test-check-pyflakes.t fails with
> 
>   +  mercurial/context.py:2009: undefined name 'ProgrammingError'
>   +  mercurial/context.py:2025: undefined name 'ProgrammingError'
>   +  mercurial/context.py:2068: undefined name 'ProgrammingError'
> 
> I'll qualify it in flight

Ah, thanks. Didn't have pyflakes installed on my test box, as it turned out...

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D616

To: phillco, #hg-reviewers
Cc: quark, martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list