D529: uncommit: move fb-extension to core which uncommits a changeset

quark (Jun Wu) phabricator at mercurial-scm.org
Mon Sep 11 18:21:51 EDT 2017


quark accepted this revision.
quark added a comment.


  Generally look good to me. I think core hg does not have very convenient commit editing APIs yet (memctx feels too low-level). I'm counting on in-memory-memory work to provide convenient APIs eventually. So I'd hold on refactoring until we have better APIs.

INLINE COMMENTS

> pulkit wrote in uncommit.py:173
> The phases.new-commit config update the phase to old.phase() if `--secret` flag is not passed. Since we don't have that I think we can use `retractboundary` to directly update to old.phase()

I think it's still safer to follow common practice and avoid using low-level `retractboundary`. It seems to be a few lines change around line 85. I guess `retractboundary` may cause surprises cases when the uncommitted node happens to exist.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D529

To: pulkit, #hg-reviewers, quark, durham
Cc: durham, quark, martinvonz, yuja, mercurial-devel


More information about the Mercurial-devel mailing list