D688: changegroup: remove changegroup dependency from revlog.addgroup
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Tue Sep 12 18:40:59 EDT 2017
martinvonz added inline comments.
INLINE COMMENTS
> revlog.py:1908
> # loop through our set of deltas
> - chain = None
> - for chunkdata in iter(lambda: cg.deltachunk(chain), {}):
nit: If I'm reading this right, you're implicitly saying that "chain" was unnecessary before this patch too. Is that correct? If so, could you extract that to separate patch and explain in the commit message why it's safe?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D688
To: durham, indygreg, #hg-reviewers
Cc: martinvonz, mercurial-devel
More information about the Mercurial-devel
mailing list