D688: changegroup: remove changegroup dependency from revlog.addgroup

durham (Durham Goode) phabricator at mercurial-scm.org
Wed Sep 13 13:44:57 EDT 2017


durham planned changes to this revision.
durham added inline comments.

INLINE COMMENTS

> martinvonz wrote in revlog.py:1908
> nit: If I'm reading this right, you're implicitly saying that "chain" was unnecessary before this patch too. Is that correct? If so, could you extract that to separate patch and explain in the commit message why it's safe?

Not quite.  Chain is necessary for the cg.deltachunk call.  Since that call has moved, so has the chain declaration.

However, there is another spot below where I say it's unnecessary to store the result of 'self._addrevision(node, ...)', since it will always return node.  I could change that to just be `chain = none` in a separate diff.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D688

To: durham, indygreg, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list