D688: changegroup: remove changegroup dependency from revlog.addgroup

[martinvonz (Martin von Zweigbergk)]

martinvonz added inline comments.

INLINE COMMENTS

> durham wrote in revlog.py:1908
> Not quite.  Chain is necessary for the cg.deltachunk call.  Since that call has moved, so has the chain declaration.
> 
> However, there is another spot below where I say it's unnecessary to store the result of 'self._addrevision(node, ...)', since it will always return node.  I could change that to just be `chain = none` in a separate diff.

Oh, that "for chunkdata in iter(lambda: cg.deltachunk(chain), {})" was tricky. Even after seeing that that was the only use, it took me a while to understand that it actually read the updated variable on every iteration. Thanks for extracting that tricky bit to a separate patch.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D688

To: durham, indygreg, #hg-reviewers
Cc: martinvonz, mercurial-devel