D688: changegroup: remove changegroup dependency from revlog.addgroup

[martinvonz (Martin von Zweigbergk)]

martinvonz added inline comments.

INLINE COMMENTS

> changegroup.py:191-192
>          node, p1, p2, deltabase, cs, flags = self._deltaheader(header, prevnode)
>          return {'node': node, 'p1': p1, 'p2': p2, 'cs': cs,
>                  'deltabase': deltabase, 'delta': delta, 'flags': flags}
>  

This is now a little unnecessary, since the first thing you do is to put it back in a tuple (much like the output from _deltaheader). Still worth the complexity and performance cost for compatibility maybe or should we make this method return a tuple?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D688

To: durham, indygreg, #hg-reviewers
Cc: martinvonz, mercurial-devel