D696: registrar: add a enum 'cmdtype' for the type of the command

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Wed Sep 13 23:23:01 EDT 2017


indygreg added a comment.


  I'm holding off on accepting this because I'd like to see an example before it is committed.
  
  Since Python 2 doesn't have real enums and Mercurial tends to shy away from object-oriented programming, I'm -0 on the use of a class here. Module-level variables with a common prefix would accomplish the same thing.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D696

To: pulkit, #hg-reviewers
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list