D705: bundle2: move exception handling into part iterator

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Thu Sep 14 12:26:26 EDT 2017


martinvonz added inline comments.

INLINE COMMENTS

> bundle2.py:368
> +    def __exit__(self, type, exc, tb):
>          if not self.iterator:
>              return

Doesn't look like this can actually happen (if used properly in a with-statement)

> bundle2.py:402
> +            if seekerror:
> +                raise exc
> +

Looks like a small change in behavior here: the debug message below used to always be printed (before this patch and also before this series). Just pointing it out in case you didn't notice. I'll let you decide if it's worth restoring the message by putting it back in a finally-block.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D705

To: durham, #hg-reviewers, indygreg
Cc: martinvonz, indygreg, mercurial-devel


More information about the Mercurial-devel mailing list