D696: registrar: add a enum 'cmdtype' for the type of the command
durham (Durham Goode)
phabricator at mercurial-scm.org
Thu Sep 14 20:30:14 EDT 2017
durham accepted this revision.
durham added a comment.
I think the name could be better, but that can be bikeshed. Stamping my approval for the concept and pattern.
INLINE COMMENTS
> registrar.py:148
>
> +class cmdtype(object):
> + """ enum for the type of command which will tell whether the command is
`cmdtype` might be overly vague, since I could imagine a number of classifications it could mean. Maybe "cmdwritetype"?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D696
To: pulkit, #hg-reviewers, durham
Cc: durham, indygreg, mercurial-devel
More information about the Mercurial-devel
mailing list