D657: revset: move weight information to predicate

[yuja (Yuya Nishihara)]

yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.


  (copied from the email thread, though I'm okay with the latest patch.)
  
  On Fri, 8 Sep 2017 18:24:44 +0000, phillco (Phil Cohen) wrote:
  
  > phillco added a comment.
  > 
  >   Constants could pobably help make it more self-documenting.
  
  Perhaps. And maybe we can add a debug command that shows a list of revset
  functions sorted by weight.

INLINE COMMENTS

> registrar.py:175
> +    diffs usually have weight 30 (ex. adds); revset reading file contents
> +    usually have weight 100 (ex. contains). Note: those values are not
> +    absolute, if the revset has a same big-O time complexity as 'contains',

contains() does not read file contents, but manifest contents.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D657

To: quark, #hg-reviewers, phillco, krbullock, singhsrb, yuja
Cc: krbullock, yuja, phillco, mercurial-devel