D680: scmutil: handle conflicting files and dirs in origbackuppath
ikostia (Kostia Balytskyi)
phabricator at mercurial-scm.org
Tue Sep 19 11:36:08 EDT 2017
ikostia requested changes to this revision.
ikostia added a comment.
This revision now requires changes to proceed.
Please wait until the `util.finddirs()` is tweaked and remove `normpath` call.
INLINE COMMENTS
> yuja wrote in scmutil.py:570
> That's probably okay now.
>
> I'm not sure if it conflicts with the long paths plan. IIRC, forward
> slash isn't allowed in `\\?\` path.
I think we should adjust `finddirs` to split on `os.path.sep`, not hardcoded `/`, then we can get rid of `util.normpath` a couple of lines above.
I am long overdue with re-sending my series, I will add this change there as well.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D680
To: mbthomas, ryanmce, #hg-reviewers, durham, yuja, ikostia
Cc: ikostia, yuja, durham, mercurial-devel
More information about the Mercurial-devel
mailing list