D730: revlog: add revmap back to revlog.addgroup

[martinvonz (Martin von Zweigbergk)]

martinvonz added a comment.


  >   A previous patch removed the revmap argument from addgroup
  
  s/A previous patch/The recent https://phab.mercurial-scm.org/rHGc8b6ed51386bf7dbcc746d5ac2835c38937a9e26/ to make it easier for others
  
  s/revmap/linkmapper/
  
  > The fix is to return linknodes as part of the delta iterator, and let the
  >  consumer choose what to do.
  
  Great, that seems easier to reason about too.
  
  It will also make it easy to update debugbundle to use deltaiter. Could you do that too?

INLINE COMMENTS

> changegroup.py:191-192
>          node, p1, p2, deltabase, cs, flags = self._deltaheader(header, prevnode)
>          return {'node': node, 'p1': p1, 'p2': p2, 'cs': cs,
>                  'deltabase': deltabase, 'delta': delta, 'flags': flags}
>  

I'll repeat my comment from https://phab.mercurial-scm.org/D688: This now seems unnecessary since the first thing you do is to convert it back into a very similar tuple. Do you think the is still useful? Maybe use a named tuple if we want the names? Either way, that's not for this patch, of course.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D730

To: durham, indygreg, #hg-reviewers
Cc: martinvonz, mercurial-devel