D727: rebase: move bookmarks with --keep (issue5682)
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Wed Sep 20 02:47:45 EDT 2017
martinvonz added a comment.
I'm tired, so I don't think I reviewed this properly, but seemed to make sense.
INLINE COMMENTS
> rebase.py:547-549
> if not self.keepf:
> - collapsedas = None
> if self.collapsef:
> collapsedas = newnode
Can combine to one condition now
> rebase.py:1522
> +
> + If `keepf` is not True, the rebase has --keep set and no nodes should be
> + removed (but bookmarks still need to be moved).
drop "not", right?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D727
To: quark, #hg-reviewers
Cc: martinvonz, mercurial-devel
More information about the Mercurial-devel
mailing list