D727: rebase: move bookmarks with --keep (issue5682)

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Wed Sep 20 12:57:11 EDT 2017


martinvonz added inline comments.

INLINE COMMENTS

> scmutil.py:588-592
> +    mapping is {oldnode: {'new': [newnode], 'move': newnode}}, where 'new'
> +    decide obsolete markers, and 'move' decide bookmark move, which could be
> +    different from new. If 'move' is not provided, it will be calculated
> +    automatically from 'new'. If 'new' is not set, the oldnode will not be
> +    removed or obsoleted.

This felt to me like it should be two separate maps, so I sent https://phab.mercurial-scm.org/D748-D750. Let me know how that looks to you.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D727

To: quark, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list