D750: rebase: move bookmarks with --keep (issue5682)

quark (Jun Wu) phabricator at mercurial-scm.org
Thu Sep 21 19:01:56 EDT 2017


quark accepted this revision.
quark added inline comments.

INLINE COMMENTS

> rebase.py:1539
> +                replacements[oldnode] = succs
> +    scmutil.cleanupnodes(repo, replacements, 'rebase', moves)
>  

In the future we might want to get the `'rebase'` name from current transaction (and enforce an active transaction in `cleanupnodes`). In that case the `name` parameter becomes less necessary and `moves` could be the 3rd argument.

I'll update the code if I'm expected to do that.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D750

To: martinvonz, #hg-reviewers, quark
Cc: quark, mercurial-devel


More information about the Mercurial-devel mailing list