D728: rebase: move working parent movement logic to scmutil.cleanupnodes

[durham (Durham Goode)]

durham requested changes to this revision.
durham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> scmutil.py:603
> +    changes will be discarded, the caller is responsible for checking the
> +    cleanness of working copy.
>      """

This seems like a bit of a bizarre feature for an api about cleaning up nodes.  Maybe cleanup nodes should return a mapping of before-to-after and the caller can use that to perform an update if they need to?  I'd rather have APIs that can be composed, than add new permutations to existing APIs.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D728

To: quark, #hg-reviewers, durham
Cc: durham, pulkit, mercurial-devel