D736: directaccess: add support for storing the type of command in func object

[durham (Durham Goode)]

durham accepted this revision.
durham added a comment.


  Minor comments, but lgtm

INLINE COMMENTS

> registrar.py:143
> +    unrecoverablewrite = "unrecoverable"
> +    recoverablewrite = "recoverable"
> +    readonly = "readonly"

Might be worth a comment describing what these mean, since it's not obvious without context.

> registrar.py:150
> +
> +        possiblecmdtypes = set(["unrecoverable", "recoverable", "readonly"])
> +        if cmdtype not in possiblecmdtypes:

These should probably refer to the class constants instead of hard coding duplicate strings.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D736

To: pulkit, #hg-reviewers, durham
Cc: durham, mercurial-devel