D737: directaccess: add support for accessing hidden commits if command is read only

[durham (Durham Goode)]

durham requested changes to this revision.
durham added a comment.
This revision now requires changes to proceed.


  Probably needs a simple test, unless that comes later in the series.

INLINE COMMENTS

> dispatch.py:898
> +                    if cmdtype == readonly:
> +                        repo = repo.unfiltered()
>              args.insert(0, repo)

This seems overly broad.  'hg log' is a readonly command, and if I do 'hg log -r HIDDEN_HASH' I want to see the hidden commit, but if I do 'hg log' I don't want to see hidden commits.  I think this change would cause hg log to show all hidden commits right?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D737

To: pulkit, #hg-reviewers, durham
Cc: durham, mercurial-devel